Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more new functions and minor changes #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Some more new functions and minor changes #5

wants to merge 4 commits into from

Conversation

acebulsk
Copy link
Contributor

Added 3 new functions:

  • findSpikesStdevWindow (a new rolling window funciton to detect outliers using standard deviation departures from the window mean)
  • deleteSpikesStdevWindow (helper function for above to set variable values to NAN where outliers exist)
  • plotFlags (helper function to plot the datetime vector output by the various QAQC functions on top of the raw data)

KevinShook
KevinShook reviewed Sep 11, 2023
View reviewed changes
R/deleteSpikes.R
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typos

KevinShook
KevinShook reviewed Sep 11, 2023
View reviewed changes
R/deleteSpikesStdevWindow.R
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have @Seealso referencing findSpikesStdevWindow

KevinShook
KevinShook reviewed Sep 11, 2023
View reviewed changes
R/findSpikesStdevWindow.R
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Seealso should also reference deleteSpikesStdevWindow

KevinShook
KevinShook reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@KevinShook KevinShook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I'd suggest adding a couple of @Seealso references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinShook KevinShook KevinShook left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acebulsk @KevinShook