Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZK-663: Bindings for new deposit circuit #98

Open
wants to merge 2 commits into
base: deposit-contract-v0-1-0
Choose a base branch
from

Conversation

kroist
Copy link
Collaborator

@kroist kroist commented Jan 22, 2025

In this PR we create bindings for DepositCircuit from shielder-circuits-v0_1_0.

@kroist kroist requested a review from pmikolajczyk41 January 22, 2025 14:56
Copy link

Transaction NameMainCurrentDifference (%)
NewAccountNative20002752000335+0.00300%
DepositNative18279301827882-0.00263%
WithdrawNative18980421898198+0.00822%

Copy link

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 2008 2235 🟡 89.84%
📄 Statements 2008 2235 🟡 89.84%
⚡ Functions 69 76 🟡 90.78%
🔀 Branches 197 199 🟡 98.99%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
zkOS-monorepo/ts/shielder-sdk/src/_generated/abi.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/index.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 9.09% 9.09% 25% 100%
zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 20.75% 20.75% 33.33% 50%
zkOS-monorepo/ts/shielder-sdk/src/client.ts 100% 100% 93.75% 100%
zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 0% 0%
zkOS-monorepo/ts/shielder-sdk/src/state/events.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/index.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/manager.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/storageSchema.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/sync.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%

gen_params_pk::<WithdrawCircuit<F, RANGE_PROOF_CHUNK_SIZE>>("withdraw", full_params);
}

fn gen_depositv_0_1_0(full_params: &Params) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: gen_deposit_v0_1_0

@@ -8,6 +8,7 @@ use shielder_circuits::{
poseidon::off_circuit::hash,
FieldExt, F,
};
use shielder_circuits_v0_1_0::consts::NUM_TOKENS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is no yes - the 0.1.0 version is the one already deployed and it doesn't have NUM_TOKENS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants