Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build contracts to /artifacts dir only and use it as source for all pipelines. #104

Merged
merged 14 commits into from
Apr 23, 2024

Conversation

deuszx
Copy link
Collaborator

@deuszx deuszx commented Apr 23, 2024

No description provided.

@deuszx deuszx force-pushed the cleanup-contract-builds branch from a4c2ed0 to 10125d5 Compare April 23, 2024 08:14
@deuszx deuszx force-pushed the cleanup-contract-builds branch from ee63b53 to cfda781 Compare April 23, 2024 09:22
amm/scripts/prepare_rust_wrappers.sh Outdated Show resolved Hide resolved
@deuszx deuszx force-pushed the cleanup-contract-builds branch from cfda781 to 62217bb Compare April 23, 2024 09:28
@deuszx deuszx force-pushed the cleanup-contract-builds branch from ad0a43d to 9c57c62 Compare April 23, 2024 10:19
@deuszx
Copy link
Collaborator Author

deuszx commented Apr 23, 2024

@h4nsu I removed the e2e tests now. There was a lot of problems w/ its dependencies:

  • old aleph-client
  • old aleph-node
  • old ink primitives

and some other mix of "forced" dependencies in Cargo.lock to make it work.

I checked all of the tests it had an we're already covering them with drink! tests.

amm/Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@h4nsu h4nsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deuszx deuszx merged commit 9dcc960 into main Apr 23, 2024
1 check passed
@deuszx deuszx deleted the cleanup-contract-builds branch April 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants