Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
does not include authentication or JWT
Add gitignore Update repository.js, user-orm.js repository.js new method to check for existance of username user-orm.js modify ormCreateUser method to check username for duplicate and throw appropriate error
Added database validation
Currently, only the frontend "node_modules" directory is being ignored. This means that the "node_modules" directory for the user-service and matching-service is still being tracked as a commit to the main repo. Let's ensure that the "node_modules" directory for the user-service and matching-service are also ignored. The necessary lines to ignore both directories have been added to the ".gitignore" file.
"App.js" file: updated file. "Navbar.js" file: created file in "components" directory. "index.css" file: updated file. Currently, there is not matching page that exists that provides the user with the ability to input their desired difficulty. We require this information to give users questions of the appropriate difficulty. Let's create a page that allows users to select their desired difficulty level of questions. This page is to be supported by our frontend microservice and the creation of this page will be done using React. The route to this service has also been created in "App.js". To view the page on your browser, enter "npm run start" in the terminal and access "http://localhost:3000/matching". The page currently allows users to select a difficulty and confirm their decision. The page also contains a navigation bar that allows users to logout. It currently returns the user back to the sign up page, a behavior that will be changed in future updates. The "index.css" file has also been updated to properly format the Matching page. This provides visual clarity to the users.
… 10-fr-2.1 # Conflicts: # frontend/package-lock.json # frontend/src/App.js
create new methods in user-controller for delete and patch
Creates new connection with sequelize database. Defines model of a match. Add logic for creating a new match.
…ect-ay2223s1-g48 into FR2.2 # Conflicts: # .gitignore
for deleting user and patching user password.
- max window sizing - small window sizing - matching page cannot scroll
UI improvement - PartII - styling of question page
Bug where user queueing for match can navigate to questions page but still be queued for a match.
Bug fix Low/Med/High to easy/medium/hard
Fix bug for creating hard question default value
Add instructions to README
Images are using .JPG instead of .jpg
Update SignupPage.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @ChengJiyuqing @tanyutao544 @joszx @lchokhoe