Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 58 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 58 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Aug 24, 2022

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.

Subscribed: @GabriellaTeh @9teMare @pnutzz-0207 @ddx-510

github-classroom bot and others added 30 commits August 24, 2022 17:12
select difficulty, find match button
Bug fixes: dark mode text color when select difficuty
Countdown modal when finding match
Update dashboard.tsx (bug fix)
Create matching service
bug fixes for matching and popup
GabriellaTeh and others added 28 commits October 18, 2022 01:29
What has been implemented:
1. Chat
2. Decline a match
3. Code room timer
4. Major UI updates

Bug fixed:
1. Not able to join room when both click accepts the first time.

Refactor:
1. FindingMatchModal
2. FoundMatchModal

Know bugs:
1. CSS bugs of the chats component
2. If user declines a match, unable to find match again
3. Chats field, if you type something, then if you want to delete everything, the first letter will stay there. This bug is due to setState of the chat
4. Signup page error message displayed despite successful signup

Whats next:
1. Question services
2. Fix the above bugs
chats, fix socket bugs
Fix login/signup error message
todo:
- pass difficulty into coderoom/index.tsx, then pass into /api/questions/[difficulty]...
1. Code runner for Python
2. Add console
Display question according to difficulty
Feature:
1. Question pannel UI
2. Statusbar room number on hover show room creation date

Bug fix:
1. Coderoom CSS now is consistent: the entire UI won't scroll
Question UI, CSS bug fix
Fancy Dashboard UI, minor bug fix
Dockerfile for GCP deployment
Fix flickering of cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants