-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
github-classroom
wants to merge
58
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit
select difficulty, find match button
Bug fixes: dark mode text color when select difficuty
Countdown modal when finding match
add FoundMatchModal
Update dashboard.tsx (bug fix)
Create matching service
matching and popup
bug fixes for matching and popup
UI updates
Add questions into json
What has been implemented: 1. Chat 2. Decline a match 3. Code room timer 4. Major UI updates Bug fixed: 1. Not able to join room when both click accepts the first time. Refactor: 1. FindingMatchModal 2. FoundMatchModal Know bugs: 1. CSS bugs of the chats component 2. If user declines a match, unable to find match again 3. Chats field, if you type something, then if you want to delete everything, the first letter will stay there. This bug is due to setState of the chat 4. Signup page error message displayed despite successful signup Whats next: 1. Question services 2. Fix the above bugs
chats, fix socket bugs
Add difficulty levels
Fix login/signup error message
todo: - pass difficulty into coderoom/index.tsx, then pass into /api/questions/[difficulty]...
1. Code runner for Python 2. Add console
Display question
Code runner
Display question according to difficulty
Feature: 1. Question pannel UI 2. Statusbar room number on hover show room creation date Bug fix: 1. Coderoom CSS now is consistent: the entire UI won't scroll
Question UI, CSS bug fix
Fancy Dashboard UI, minor bug fix
Dockerfile for GCP deployment
Fix flickering of cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @GabriellaTeh @9teMare @pnutzz-0207 @ddx-510