Refactor: Metrics processor #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
reviewed
Sep 24, 2024
| if namespace not in self.merged_data: | ||
| self.merged_data[namespace] = {} | ||
| if pod not in self.merged_data[namespace]: | ||
| self.merged_data[namespace][pod] = {"metrics": {}} |
There was a problem hiding this comment.
This and the other lines in this file which check for a key before providing an initial value can be simplified with setdefault(). Docs here.
>>> a = {'a': []}
>>> a.setdefault('a', 'blah')
[]
>>> a.setdefault('b', 'blah')
'blah'
>>> a
{'a': [], 'b': 'blah'}
>>> Or/And, you can make use of a defaultdict, which provides an initial value for all keys which don't exist. Docs here.
>>> from collections import defaultdict
>>> b = defaultdict(dict)
>>> b['missing_key']
{}
>>> b
defaultdict(<class 'dict'>, {'missing_key': {}})Or a combination of both of the above. (setdefault a defaultdict)
There was a problem hiding this comment.
that's useful. I updated it to use setfedault in this case.
This commit takes the methods merge_metrics and condense_metrics out of utils.py and puts them into the MetricsProcessor class. The callers have been updated to instantiate this class and use the methods provided by it. The unit tests have been moved to their own module. The tests needed some minor updates to run but otherwise have remained unchanged.
…amespace Earlier the keys were contacted `namespace` + `pod_name`. So, this commit changes the dictionary from `merged_data[namespace+pod_name]` to `merged_data[namespace][pod_name]` which I think is a better way to organize this. The tests have been updated to work with the new structure.
naved001
force-pushed
the
refactor/metrics_processor
branch
from
c878034 to
e6837e9
Compare
knikolla
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new metrics processor class that exposes methods for merging and condensing metrics. The actual methods remain largely the same except that they restructure the data differently (more in the commit message).
I have some more refactoring planned for those 2 methods specifically, but I will do that in a separate PR.