Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix #606: Overflow Issue Resolved #607

Merged

Conversation

Gaurav-Kushwaha-1225
Copy link
Contributor

Description

This overflow issue was due to NumberPicker widget, when the min and value arguments of this widget were 1 or greater, then it shows this overflow error.

Proposed Changes

How I resolved?

  • I changed the min and default value of numMathsQuestions as 0 and 0.obs, respectively.
  • Then, in Save button of dialog, it will check for condition, that for setting controller.isMathsEnabled.value to true the number of questions should be greater than 0.
  • Else, it will remain false by default and Maths Challenge will not be enabled until you select number questions to be greater than 0.

Fixes #606

Screenshots

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@AryanSarafDev AryanSarafDev merged commit 5efcb01 into CCExtractor:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: RenderFlex overflowed by Infinity pixels in Maths Challenge Setup
2 participants