[FEAT] Add bitstream module in lib_ccxr
#1649
Open
+798
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib_ccx/cc_bitstream.h
Outdated
| @@ -25,6 +24,9 @@ struct bitstream | |||
| // increased by the calling function, or not. | |||
| unsigned char *_i_pos; | |||
| int _i_bpos; | |||
| #ifndef DISABLE_RUST | |||
| void *rust_bs; // Pointer to Rust's Bitstream struct | |||
There was a problem hiding this comment.
Could we construct / deconstruct the struct when passing to rust instead of storing a different pointer?
There are other files, where you can see the to_ctype()
There was a problem hiding this comment.
yaa surely, this should be a better approach rather than having to maintain two structures. I will try to fix it in my next commit
There was a problem hiding this comment.
@prateekmedia , I have made changes in the bitstream.rs file , can you please review it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This PR migrates the bitstream functionality from C to Rust while maintaining backward compatibility by creating a new Rust implementation in
lib_ccxr/src/common/bitstream.rsand connecting it to the existing C code through FFI bindings.