Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

477 add princeton met forcing #524

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ccarouge
Copy link
Member

@ccarouge ccarouge commented Jan 13, 2025

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Add the Princeton forcing as part of the changes brought by the groundwater work. The implementation follows the way it was initially done for the groundwater with the following differences:

  • adaptation to the refactoring of the driver
  • bug fixed in renameFiles_Princeton() (added the "BACK" keyword to INDEX() call) and modification in cable_input since Princeton does not provide a file for snowfall.

Fixes #477

Type of change

Please delete options that are not relevant.

  • New

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Testing

When running with the Princeton forcing on for the year 1948, I have tested that the forcings output by CABLE are identical to the values in the input files. This is true except for the pressure variable. This variable goes through a unit conversion (Pa to hPa) and type conversions (double to real). This introduce a small noise in the comparison with a maximum difference of 0.008 Pa that is negligible.

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--524.org.readthedocs.build/en/524/

Copy link
Member Author

@ccarouge ccarouge Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccarouge might need something more. See l.877 in the GW PR.
There should be something for the output as well, see l. 989 in the GW PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Princeton met forcing option for groundwater work
1 participant