feat: remove name from project patch

Byzanteam · Aug 26, 2024 · 8ccdb08 · 8ccdb08
1 parent c090c13
commit 8ccdb08
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 14 deletions.
diff --git a/main.ts b/main.ts
@@ -1,4 +1,5 @@
-import { Command, CompletionsCommand } from "@cliffy/command";
+import { Command } from "@cliffy/command";
+import { CompletionsCommand } from "@cliffy/command/completions";
 
 import denoJson from "./deno.json" with { type: "json" };
 

diff --git a/src/jcli/config/project-json-patch-builder.ts b/src/jcli/config/project-json-patch-builder.ts
@@ -130,14 +130,7 @@ function equal(value: PathNode): BuilderNodeFilter {
   return (pathNode) => pathNode === value;
 }
 
-function buildNamePatch(
-  _op: DiffPatchOp,
-  value: unknown,
-  patch: ProjectPatch,
-): void {
-  /* op must be "replace" */
-  patch.name = value as string;
-}
+function skip(_op: DiffPatchOp, _value: unknown, _patch: ProjectPatch): void {}
 
 function buildTitlePatch(
   _op: DiffPatchOp,
@@ -270,7 +263,7 @@ function buildScopesPatch(
 }
 
 export const builder = new BuilderNode({ name: "root" }).children([
-  new BuilderNode({ name: "name" }).on(equal("name")).do(buildNamePatch),
+  new BuilderNode({ name: "name" }).on(equal("name")).do(skip),
   new BuilderNode({ name: "title" }).on(equal("title")).do(buildTitlePatch),
 
   new BuilderNode({ name: "capabilities" }).on(equal("capabilities")).children([

diff --git a/src/jcli/config/project-json.ts b/src/jcli/config/project-json.ts
@@ -174,7 +174,6 @@ export type ProjectPluginInstancePatch =
   | ProjectPluginInstanceDeletePatch;
 
 export interface ProjectPatch {
-  name?: string;
   title?: string;
   capabilities: Array<ProjectCapabilityPatch>;
   instances: Array<ProjectPluginInstancePatch>;

diff --git a/test/jcli/config/project-json_test.ts b/test/jcli/config/project-json_test.ts
@@ -45,7 +45,6 @@ describe("ProjectDotJSON", () => {
 
       assertNotEquals(diff, undefined);
       assertObjectMatch(diff!, {
-        name: "bar",
         capabilities: [],
         instances: [],
       });

diff --git a/test/subcommands/push/action/push-configuration_test.ts b/test/subcommands/push/action/push-configuration_test.ts
@@ -80,7 +80,6 @@ describe("configuration", () => {
       assertEquals(patches!.length, 1);
 
       assertObjectMatch(patches![0], {
-        name: "name",
         title: "title",
         capabilities: [
           {
@@ -146,7 +145,6 @@ describe("configuration", () => {
       assertEquals(patches!.length, 1);
 
       assertObjectMatch(patches![0], {
-        name: "name",
         title: "title",
         capabilities: [],
         instances: [],