This repository has been archived by the owner on May 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
Add Landing Page #560
Open
zacel
wants to merge
46
commits into
BustByte:master
Choose a base branch
from
zacel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Landing Page #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odified urls.ts to include /landing
…in server response
…ates are wrong for most countries
… lat,long inside that range is a whole project in itself, I think it could maybe be a saas (there are like 10 companies selling the ability to go lat,long->timezone but I couldn't find any in reverse). I think asking for location is privacy friendly because its opt in. Whether or not we go to the users location, after 5 seconds the map starts cycling through all the websites location on the map. Their name and a third link to them is displayed underneath. Still todo: 1) I need to get accurate lat, long for each country. My numbers are way off. There don't seem to be any data available for this so I will just find them manually tomorrow (I have a map🗺). 2) Where does the About coronastatus button link to?
Use custom map theme.
-add Romania to countries.json -fix lots of countries coordinates -stylizing landing.ejs
… to center the map on at start - updated the python script to gather country location/site data - clean up the javascript parts of landing.js
-currently the request takes a full 3 seconds to complete on first load -this is the last version with the countries.json version of landing page intact
-remove all references to countries.json in server.ts and ejs part of landing.ejs -convert landing.ejs to make httprequest to api/countries and use that data -move all landing.ejs startup function calls into callback from httprequest
cache countries when the server starts
@zacel I checked out your PR. Looking good. I noticed the link to selected country from "Contribute Now" is broken. Is this supposed to work already? |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a landing page as first designed in: https://www.figma.com/file/WriP7XWOZbni3X94J0asVX/CoronaStatus?node-id=6090%3A872
The idea began with this issue:
#188
It was created with a lot of work from @amritnagi. He did most of the designing and lots of the developing. Thank you @lseelenbinder for customizing the map layers to hide country names. @jelbazi was also a big help in laying out the design.
This pr already conforms to the fix-lat-lng-order branch, since that info is used here.
It does not show the report data from each country yet as I haven't found a way to do that without making requests to each country site every time the page loads.
After a new country is added to
app/countrySpecific
thenstatic/countries.json
must be updated for it to show up on the landing page. This can be done by running thegenCountries.py
script which is located in the root directory.The countries can all be viewed on a map.
The map cycles through countries and shows their name (in their language), their flag, and a link to their site.
The map cycling animation can be played and paused.
Visitors can access a full list of countries using any of the
contribute now!
buttonsVisitors have many ways to contribute
To Be translated before merging this pr
It adds a route for accessing the landing page in
app/routes/various-routes.ts
. Right now the route is /landing in every language so that may have to be updated.Here is the list of strings that will have to be localized to use the landing page in other languages: