This repository has been archived by the owner on May 2, 2022. It is now read-only.
Sort translation files by keys #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbocinec
requested review from
fossecode,
Kilian and
michaelmcmillan
as code owners
fossecode
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a huge mess in the translations and it's hard to keep it in sync. This complements the effort started in #481 and simply just sort translation files by the keys.
Then checking for the missing translations is just doing diff between the file that we consider as a base/authoritative (i guess it's
en.jsonorno.json) what massively speeds up translations.Command used for the sort:
for file in *.json; do jq -S '.' $file > $file.sorted; mv $file.sorted $file; done