-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
select nwb traces according to v_file field #174
Conversation
AurelienJaquier
commented
Mar 21, 2024
- also match ecodes with non-matching capital/lower letters, e.g. IDRest with IDrest
@darshanmandge do you know if the BBP nwb files always have the igor file in description? |
They should usually have the description to have a provenance of the corresponding igor files used constructing the nwb files. We need to sample and check some files from different datasets. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 74.12% 73.77% -0.35%
==========================================
Files 38 38
Lines 2396 2410 +14
==========================================
+ Hits 1776 1778 +2
- Misses 620 632 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for implementing case-insensitive ecode comparison 👍