Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select nwb traces according to v_file field #174

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

  • also match ecodes with non-matching capital/lower letters, e.g. IDRest with IDrest

@AurelienJaquier AurelienJaquier self-assigned this Mar 21, 2024
@AurelienJaquier
Copy link
Collaborator Author

@darshanmandge do you know if the BBP nwb files always have the igor file in description?

@darshanmandge
Copy link
Contributor

They should usually have the description to have a provenance of the corresponding igor files used constructing the nwb files. We need to sample and check some files from different datasets.

@AurelienJaquier AurelienJaquier requested a review from ilkilic March 21, 2024 10:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 73.77%. Comparing base (e49d247) to head (c740a44).

Files Patch % Lines
bluepyefe/nwbreader.py 15.78% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   74.12%   73.77%   -0.35%     
==========================================
  Files          38       38              
  Lines        2396     2410      +14     
==========================================
+ Hits         1776     1778       +2     
- Misses        620      632      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for implementing case-insensitive ecode comparison 👍

@AurelienJaquier AurelienJaquier merged commit ddd5335 into BlueBrain:master Mar 21, 2024
4 checks passed
@AurelienJaquier AurelienJaquier deleted the nwb-select branch March 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants