Fix sampling #105
Merged
Fix sampling #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of small fixes combined in a single commit: 1) Variable idenfiers live inside a different namespace than type names, so we don't need to check for clashes. 2) Witness names should begin with a letter. This ensures that witness::NAME is valid Rust. 3) Jet names include the trailing `::`, so they cannot clash with function names. 4) Type aliases must not redefine a builtin type such as `bool`.
Introduce a new wrapper type, AliasName, for strings that are valid alias names. This makes sure that alias names are correctly sampled by the Arbitrary trait. Fixes BlockstreamResearch#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104