Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop BarcodeLib dependency #171

Closed
wants to merge 2 commits into from
Closed

Drop BarcodeLib dependency #171

wants to merge 2 commits into from

Conversation

primo-ppcg
Copy link
Collaborator

@primo-ppcg primo-ppcg commented Jun 24, 2023

Drops the BarcodeLib dependency.

Fixes #145
Fixes #154
Fixes #170

Additionally:

  • Code39 and I2of5 now support variable WideToNarrow ratio.
  • EAN13 interpretation lines now respect chosen font face.
  • EAN13 are no longer drawn with a white background.

This PR will likely remain in draft status until the next release of ZXing.NET, as I am waiting on the resolution of a few issues:
micjahn/ZXing.Net#503
micjahn/ZXing.Net#504

@YipingRuan
Copy link
Contributor

@primo-ppcg
Should this PR remain "work in progress"?

@YipingRuan YipingRuan changed the base branch from master to develop September 19, 2023 02:28
@primo-ppcg
Copy link
Collaborator Author

@primo-ppcg Should this PR remain "work in progress"?

Unfortunately, Code128 barcodes containing a space will cause an error with the current version of ZXing.Net (micjahn/ZXing.Net#504). This is due to a bug in the parent project that's also been corrected (zxing/zxing#1658). This PR unfortunately cannot be merged until the next version of ZXing.Net is released.

@ivanjx
Copy link

ivanjx commented Nov 6, 2023

any progress? all the external issues mentioned are fixed.

@primo-ppcg
Copy link
Collaborator Author

It's becoming a long wait for the next release of ZXing.NET. I'm going to get some of the open PRs merged and rework this for all barcodes except Code 128.

@YipingRuan
Copy link
Contributor

@primo-ppcg
Thank you, will you also include the SixLabors.ImageSharp fixes, like #223 ?

@primo-ppcg
Copy link
Collaborator Author

@primo-ppcg Thank you, will you also include the SixLabors.ImageSharp fixes, like #223 ?

For sure, as per the github advisory.

@primo-ppcg primo-ppcg closed this Apr 25, 2024
@primo-ppcg primo-ppcg deleted the drop-barcodelib branch April 25, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment