[WIP] Extensions catalogue #36
Conversation
| Scenario: Releasing a stable extension | ||
| Given "behat/symfony2-extension" extension was created in "Behat/Symfony2Extension" | ||
| When I release "Behat/Symfony2Extension" version "v2.0.0" | ||
| Then extension catalogue should contain 1 extension |
There was a problem hiding this comment.
I would reword the step by adding the the article at the beginning. It would read better
|
Should the extension have a reference to the repository hosting its code to allow accessing it easily from the UI or no ? |
|
I would add a scenario saying that releasing the Behat documentatio itself does not register it as an extension |
I don't know yet :) I just follow the needs and see where they drive me.
I think the last scenario ( |
No it does not. It is release Behat/MinkExtension, not Behat/docs (or it is trying to cover this case but in a confusing way) |
|
@stof done :) Thanks for wearing tester hat ;) |
everzet
force-pushed
the
feature/extensions
branch
2 times, most recently
from
f318134 to
cde0e64
Compare
|
Domain done. Infra and UI is coming next. |
| @@ -0,0 +1,26 @@ | |||
| <?php | |||
|
|
|||
| namespace Dictionaries; | |||
There was a problem hiding this comment.
Given that all these traits are about transformations, using a Transformation namespace might be better
There was a problem hiding this comment.
Good point :) I was thinking about something more generic, but we don't need to be generic ATM. Maybe we'll never be.
Purely for readability purposes
Just to improve general readability and UL
everzet
force-pushed
the
feature/extensions
branch
from
3cf64fe to
a62a616
Compare
Also switch to use Composer autoloader instead of one built into behat
| private function repositoryContainsDocs(Repository $repository, Version $version) | ||
| { | ||
| return $this->existsInRepositoryVersion($repository, $version, 'index.rst') | ||
| || $this->existsInRepositoryVersion($repository, $version, 'doc/index.rst'); | ||
| || $this->existsInRepositoryVersion($repository, $version, 'doc/index.rst'); |
This feature is not ready yet, but that's ok. I think this branch has a lot of great stuff in it to grant a merge already. We'll work on UI stuff in separate PR.
Implements & Closes #12