2024.5.9.1

[N6REJ]

PR Type

enhancement, configuration changes

---

Description

• Added initialization scripts for MySQL versions 8.0.37 and 8.4.
• Introduced new configuration files and settings for MySQL versions 8.0.37 and 8.4.
• Updated bundle release version in build.properties.
• Added new MySQL versions to releases.properties.

---

Changes walkthrough 📝

Relevant files

Configuration changes

10 files init.bat Add MySQL 8.0.37 Initialization Script                                      bin/mysql8.0.37/init.bat Added initialization script for MySQL 8.0.37 +3/-0      init.bat Add MySQL 8.4 Initialization Script                                            bin/mysql8.4/init.bat Added initialization script for MySQL 8.4 +3/-0      bearsampp.conf Add Configuration for MySQL 8.0.37                                              bin/mysql8.0.37/bearsampp.conf Added configuration file for MySQL 8.0.37 +10/-0    my.ini Add MySQL 8.0.37 Configuration Settings                                    bin/mysql8.0.37/my.ini Added MySQL 8.0.37 configuration settings +55/-0    my.ini.ber Add Backup Configuration for MySQL 8.0.37                                bin/mysql8.0.37/my.ini.ber Added MySQL 8.0.37 configuration settings (backup) +55/-0    bearsampp.conf Add Configuration for MySQL 8.4                                                    bin/mysql8.4/bearsampp.conf Added configuration file for MySQL 8.4 +10/-0    my.ini Add MySQL 8.4 Configuration Settings                                          bin/mysql8.4/my.ini Added MySQL 8.4 configuration settings +55/-0    my.ini.ber Add Backup Configuration for MySQL 8.4                                      bin/mysql8.4/my.ini.ber Added MySQL 8.4 configuration settings (backup) +55/-0    build.properties Update Bundle Release Version                                                        build.properties Updated bundle release version to 2024.5.9 +1/-1      releases.properties Add New MySQL Versions to Release Properties                          releases.properties Added new MySQL versions to the release properties +5/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR Description updated to latest commit (131fb2b)

• Copy walkthrough table to "Files Changed" Tab

[qodo-merge-pro]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	3, because the PR involves multiple configuration and initialization scripts across different versions of MySQL. The changes are extensive but mostly repetitive across different versions, which simplifies the review process. However, the reviewer needs to ensure that paths and configurations are correctly set for each version, which requires careful attention to detail.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The use of --initialize-insecure in the initialization scripts (init.bat) for MySQL might pose a security risk as it initializes the server without a root password. This should be addressed or documented to ensure that it is only used in safe, development environments.
	Configuration Duplication: The configuration files for different MySQL versions (my.ini and my.ini.ber) are very similar. Consider abstracting common configurations to a shared file to reduce duplication and potential errors in future updates.
🔒 Security concerns	- Sensitive Information Exposure: The initialization scripts use --initialize-insecure, which might lead to the creation of a MySQL instance without a secure root password. This should be carefully managed or revised to avoid unintentional security vulnerabilities in deployment environments.

[qodo-merge-pro]

PR Code Suggestions ✨

Category	Suggestions
Enhancement	Add error handling to the MySQL server initialization command. Consider adding error handling to check if the MySQL server initialization was successful. This can be done by checking the error level after executing the command. bin/mysql8.0.37/init.bat [3] %~dp0bin\mysqld.exe --initialize-insecure +IF %ERRORLEVEL% NEQ 0 ( + ECHO Initialization failed. + EXIT /B %ERRORLEVEL% +)
Security	Replace insecure initialization with a secure method. It is recommended to avoid using insecure settings such as --initialize-insecure in production environments. Consider using secure initialization methods. bin/mysql8.0.37/my.ini [3] -%~dp0bin\mysqld.exe --initialize-insecure +%~dp0bin\mysqld.exe --initialize
Best practice	Uncomment and configure InnoDB settings if necessary. The innodb_flush_log_at_trx_commit and innodb_lock_wait_timeout options are commented out. If these settings are necessary for your configuration, consider uncommenting and adjusting them as needed. bin/mysql8.0.37/my.ini [27-28] -#innodb_flush_log_at_trx_commit = 1 -#innodb_lock_wait_timeout = 50 +innodb_flush_log_at_trx_commit = 1 +innodb_lock_wait_timeout = 50
Possible issue	Correct the MySQL base and data directory paths. Ensure that the basedir and datadir paths are correctly set for the MySQL installation to avoid runtime errors. bin/mysql8.4/my.ini [16-18] -basedir=~BEARSAMPP_LIN_PATH~/bin/mysql/mysql8.4 -datadir=~BEARSAMPP_LIN_PATH~/bin/mysql/mysql8.4/data +basedir=C:\path\to\mysql8.4 +datadir=C:\path\to\mysql8.4\data
Bug	Correct the typo in the MySQL server character set configuration. The character-set-server is set to UTF8MB4 which might be a typo. The correct character set name is utf8mb4. bin/mysql8.4/my.ini [32] -character-set-server=UTF8MB4 +character-set-server=utf8mb4

[jwaisner]

@N6REJ , looks like some conflicts need resolved on this one.