-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to request SiriKit permissions to platform interface. #1266
Conversation
* Adding SiriKit permissions * Fix tests --------- Co-authored-by: Maurits van Beusekom <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
===========================================
+ Coverage 71.42% 93.47% +22.04%
===========================================
Files 1 6 +5
Lines 35 92 +57
===========================================
+ Hits 25 86 +61
+ Misses 10 6 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TimHoogstrate <[email protected]>
Adds support to request SiriKit permissions to platform interface.
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.