Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photosAddOnly setup for iOS to Podfile in README #1254

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

c15yi
Copy link
Contributor

@c15yi c15yi commented Dec 29, 2023

Replace this paragraph with a short description of what issue this pull request (PR) solves and provide a description of the change. Consider including before/after screenshots.

The to be commented out comment for only adding photos to the library under iOS (NSPhotoLibraryAddUsageDescription) was missing in the README.

List at least one fixed issue.
#980

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (978dbeb) 71.42% compared to head (9a06ce1) 71.42%.
Report is 7 commits behind head on main.

❗ Current head 9a06ce1 differs from pull request most recent head 5129a6d. Consider uploading reports for the commit 5129a6d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           1        1           
  Lines          35       35           
=======================================
  Hits           25       25           
  Misses         10       10           
Flag Coverage Δ
unittests 71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimHoogstrate TimHoogstrate self-assigned this Jan 30, 2024
Copy link
Contributor

@TimHoogstrate TimHoogstrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ChristianNavolskyi, Thanks for your input. This is a really good find. Could you update the CHANGELOG.md to add a description of the change and increase the version patch number? The change looks great. Thanks

@TimHoogstrate TimHoogstrate added the status: needs more info We need more information before we can continue work on this issue. label Jan 31, 2024
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor formatting changes that I will quickly apply.

permission_handler/CHANGELOG.md Outdated Show resolved Hide resolved
permission_handler/CHANGELOG.md Outdated Show resolved Hide resolved
permission_handler_apple/CHANGELOG.md Outdated Show resolved Hide resolved
permission_handler_apple/CHANGELOG.md Outdated Show resolved Hide resolved
@mvanbeusekom mvanbeusekom merged commit 669aff8 into Baseflow:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs more info We need more information before we can continue work on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants