Refactor: Port PackageManager.canRequestPackageInstalls (Android)
#1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
mvanbeusekom
requested changes
Nov 10, 2023
Comment on lines
84
to
86
| List<String> permissions, [ | ||
| int? requestCode, | ||
| ) { | ||
| ]) { |
There was a problem hiding this comment.
Can we make the requestCode an optional named parameter, instead of an optional positional parameter?
Named parameters are more developer friendly as they show up better in the IDE and also allows for a bit more flexibility in case we need to add additional parameters.
Comment on lines
119
to
121
| Intent intent, | ||
| Intent intent, [ | ||
| int? requestCode, | ||
| ) { | ||
| ]) { |
There was a problem hiding this comment.
Can we make the requestCode an optional named parameter, instead of an optional positional parameter?
Named parameters are more developer friendly as they show up better in the IDE and also allows for a bit more flexibility in case we need to add additional parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the necessary Android SDK bits for checking whether an application can request package installs.
Closes https://github.com/orgs/Baseflow/projects/9/views/1?pane=issue&itemId=39927253.
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).next.dart format .and committed any changes.flutter analyzeand fixed any errors.