-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split MountainRange into MountainRangeBasic #11
Open
frozenfrank
wants to merge
9
commits into
BYUHPC:main
Choose a base branch
from
frozenfrank:8-split-mountain-range-into-basic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Split MountainRange into MountainRangeBasic #11
frozenfrank
wants to merge
9
commits into
BYUHPC:main
from
frozenfrank:8-split-mountain-range-into-basic
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove header_size calculations - Remove ability to configure default_dt
frozenfrank
changed the title
8 split mountain range into basic
Split MountainRange into MountainRangeBasic
Jan 10, 2025
I think I'm actually against creating the MountainRangeBasic file. If students can't figure out C++ enough to know what's needed or not they aren't going to do well in the course. It should be "harder" so they drop if needed. It also forces them to read all the code instead of copy/paste/tweak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8.
Provides a much simpler version of
MountainRange
that more closely parallels what is required of students from Phase 1.Link to MountainRangeBasic sequence diagram.