fix: 어드민 히스토리 기능 수정 #1131
Merged
fix: 어드민 히스토리 기능 수정 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix/1071-modify-admin-history
… fix/1071-modify-admin-history
… fix/1071-modify-admin-history
This reverts commit 7c1ecb2.
Soundbar91
requested review from
seongjae6751,
daheeParkk,
kwoo28 and
duehee
duehee
approved these changes
Dec 13, 2024
| @Schema(description = "요청 시간", example = "2019-08-16-23-01-52", requiredMode = REQUIRED) | ||
| @JsonFormat(pattern = "yyyy-MM-dd-HH-mm-ss") | ||
| @Schema(description = "요청 시간", example = "2019-08-16 23:01:52", requiredMode = REQUIRED) | ||
| @JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss") |
| limit = DEFAULT_LIMIT; | ||
| } | ||
| if (Objects.isNull(sort)) { | ||
| sort = CREATED_AT_DESC; |
There was a problem hiding this comment.
A
static import는 좋은데, 위는 CREATED_AT_DESC는 static import를 사용하고, 아래의 Sort.CREATED_AT_ASC를 사용한다면 조금 모호하게 의미파악이 되지 않을까 생각이 드네요👀
There was a problem hiding this comment.
밑에도 static import로 변경하겠습니다 !
kwoo28
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
이전에 닫힌 PR을 다시 올립니다.
로깅 어노테이션을 적용해서 다시 PR을 올리려했는데, 잘 되지 않아서 리펙토링 과정에서 어노테이션을 적용할려고 합니다.