Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 이미지 업로드 알림 로직 분리 #1124

Merged
merged 17 commits into from
Dec 15, 2024
Merged

refactor: 이미지 업로드 알림 로직 분리 #1124

merged 17 commits into from
Dec 15, 2024

Conversation

dradnats1012
Copy link
Contributor

🔥 연관 이슈

변경 이유 :

기존에는 식단 이미지 업로드와 동시에 알림이 발송 됐는데 
그렇게 되면 모든 식단이 올라오지 않는 경우에도 알림이 발송되어 사용자들에게 좋지 않은 경험이 될것이라고 판단되어 
6분마다 검사후 특정 날짜와 타입에 대하여 모든 이미지가 업로드 되면 알림을 발송하기 위해서

🚀 작업 내용

  1. 식단 품절 알림 로직 스케줄러로 분리

변경된 로직

  • 시간을 기준으로 식단 타입을 가져옴
  • 날짜와 타입을 기준으로 해당하는 식단을 가져옴
  • 해당하는 식단의 모든 이미지가 존재하는지 판단
  • 오픈시간(1시간 전부터)인지 판단
  • case : 모든 이미지 존재 && 오픈시간
    • case : Redis에 해당하는 키가 있음
      • 메서드 종료
    • case : Redis에 해당하는 키가 없음
      • 알림 발송, Redis에 키값 넣기
  • case : 오픈 시간 10분 전 이후 && Redis에 해당하는 키가 없음 && 이미지가 하나라도 있음
    • 알림 발송, Redis에 키값 넣기

💬 리뷰 중점사항

오래 걸렸네요..
혹시라도 이상한 부분 있는지 확인 부탁드립니다!

@github-actions github-actions bot added the 리팩터링 리팩터링을 위한 이슈입니다 label Dec 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024 •
edited
Loading

Unit Test Results

346 tests  +2   345 ✔️ +2   1m 38s ⏱️ +4s
  41 suites ±0       1 💤 ±0 
  41 files   ±0       0 ❌ ±0 

Results for commit c505ea6. ± Comparison against base commit 885875d.

♻️ This comment has been updated with latest results.

@dradnats1012 dradnats1012 self-assigned this Dec 7, 2024
Soundbar91
Soundbar91 requested changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@Soundbar91 Soundbar91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

브랜치에 과거의 잔재가 남아있어요..!
확인 부탁드립니다 (__)

ImTotem
ImTotem approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@ImTotem ImTotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict 해결해주세용~

Choon0414
Choon0414 approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@Choon0414 Choon0414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

src/main/java/in/koreatech/koin/domain/coop/util/CoopScheduler.java

@Scheduled(cron = "0 0/6 7 * * *")
@Scheduled(cron = "0 30/6 10-11 * * *")
@Scheduled(cron = "0 30/6 16-17 * * *")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A
한번에 여러 개 되는 지는 몰랐네요

src/main/java/in/koreatech/koin/domain/coop/service/CoopService.java Outdated
private final CoopRepository coopRepository;
private final UserTokenRepository userTokenRepository;
private final CoopShopService coopShopService;
private final PasswordEncoder passwordEncoder;
private final JwtProvider jwtProvider;
List<String> placeFilters = Arrays.asList("A코너", "B코너", "C코너");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C
여기 접근 제어 안해줘도 되나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 나이스입니다

@dradnats1012
Merge branch 'develop' into refactor/image-upload-notify-seperation
ef80465 
# Conflicts:
#	src/main/java/in/koreatech/koin/domain/coop/service/CoopService.java
@dradnats1012
fix: conflict 해결
48f04c3
@dradnats1012
fix: 리뷰 반영
c505ea6
@dradnats1012 dradnats1012 merged commit b4a0e4c into develop Dec 15, 2024
4 checks passed
@dradnats1012 dradnats1012 deleted the refactor/image-upload-notify-seperation branch December 15, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Choon0414 Choon0414 Choon0414 approved these changes

@Soundbar91 Soundbar91 Soundbar91 approved these changes

@ImTotem ImTotem ImTotem approved these changes

@songsunkook songsunkook Awaiting requested review from songsunkook

@DHkimgit DHkimgit Awaiting requested review from DHkimgit

@kih1015 kih1015 Awaiting requested review from kih1015

Assignees

@dradnats1012 dradnats1012

Labels
리팩터링 리팩터링을 위한 이슈입니다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dradnats1012 @ImTotem @Soundbar91 @Choon0414