Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS file #2371

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update CODEOWNERS file #2371

wants to merge 2 commits into from

Conversation

nilo-ms
Copy link
Contributor

@nilo-ms nilo-ms commented Oct 16, 2024

Proposed changes

Package.swift should have shared ownership between @AzureAD/AppleIdentityTeam and @AzureAD/MSAL-ObjC-CIAM team.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

@nilo-ms nilo-ms requested a review from a team as a code owner October 16, 2024 16:52
@nilo-ms nilo-ms requested review from ameyapat and mipetriu and removed request for a team October 16, 2024 16:52
@@ -2,9 +2,10 @@
# Unless a later match takes precedence, these users will be requested

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@nilo-ms nilo-ms changed the base branch from amepatil/update-dev-with-1.6.1 to dev October 16, 2024 16:56
@ameyapat
Copy link
Contributor

Cloned PR for danilo/update-codeowner-file


AI description (iteration 1)

PR Classification

Code cleanup

PR Summary

This pull request involves the cleanup and simplification of the Main.storyboard file in the macOS test application.

  • Main.storyboard: Removed redundant stackView and textField elements, adjusted frame sizes, and simplified constraints.

AI description (iteration 1)

PR Classification

Code cleanup

PR Summary

This pull request involves the cleanup and simplification of the Main.storyboard file in the macOS test application.

  • Main.storyboard: Removed redundant stackView and textField elements, adjusted frame sizes, and simplified constraints.

1 similar comment
@ameyapat
Copy link
Contributor

Cloned PR for danilo/update-codeowner-file


AI description (iteration 1)

PR Classification

Code cleanup

PR Summary

This pull request involves the cleanup and simplification of the Main.storyboard file in the macOS test application.

  • Main.storyboard: Removed redundant stackView and textField elements, adjusted frame sizes, and simplified constraints.

AI description (iteration 1)

PR Classification

Code cleanup

PR Summary

This pull request involves the cleanup and simplification of the Main.storyboard file in the macOS test application.

  • Main.storyboard: Removed redundant stackView and textField elements, adjusted frame sizes, and simplified constraints.

@nilo-ms nilo-ms enabled auto-merge (squash) January 10, 2025 08:08
@ameyapat
Copy link
Contributor

Cloned PR for danilo/update-codeowner-file


AI description (iteration 1)

PR Classification

Documentation update

PR Summary

This pull request updates the CODEOWNERS file to adjust code ownership assignments.

  • CODEOWNERS: Added Package.swift to the co-ownership of @AzureAD/AppleIdentityTeam and @AzureAD/MSAL-ObjC-CIAM, and removed @AzureAD/MSAL-ObjC-CIAM as the sole owner of Package.swift.

@nilo-ms nilo-ms added the skip-native-auth-e2e-tests Only include this if Native Auth E2E tests are blocking the PR validation label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-native-auth-e2e-tests Only include this if Native Auth E2E tests are blocking the PR validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants