-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Updating get_seed_prompt_groups to include individual seed_prompts #651
base: main
Are you sure you want to change the base?
MAINT: Updating get_seed_prompt_groups to include individual seed_prompts #651
Conversation
@@ -55,7 +55,7 @@ def __init__( | |||
metadata: Optional[Dict[str, str]] = None, | |||
parameters: Optional[List[str]] = None, | |||
prompt_group_id: Optional[uuid.UUID] = None, | |||
sequence: Optional[int] = None, | |||
sequence: Optional[int] = 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default of 0 matches promptRequestResponses that are only made up of a single piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't sequence 0 the first turn? If you have 3 pieces, wouldn't they all get sequence 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is probably what we want by default I would guess? We could require this to be set, but I'd imagine most seedPrompts are only the first turn.
Previously, when calling
get_seed_prompt_groups
it would only return groups with a specified group_id and not include seed_prompts that matched the filter criteria if the group_id was not set. Additionally, groups had to be specified one per yaml file.This PR makes it easier to manage
SeedPrompts
andSeedPromptGroups
within yaml files and when querying from the database.