Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Replacing NormalizerRequestPieces with SeedPrompts #648

Merged

Conversation

rlundeen2
Copy link
Contributor

@rlundeen2 rlundeen2 commented Jan 17, 2025

A good way to visualize how this is useful is to imagine sending a bunch of multi-modal prompts.

Before this change, you would load SeedPrompts from somewhere then have code to convert them to NormalizerRequestPieces, and then send them.

Now, you can load SeedPrompts from somewhere and send them without converting them first.

In summary, this PR does the following:

  • Removing NormalizerRequestPiece so the normalizer can send SeedPrompts without the extra step
  • Refactoring interfaces so they use SeedPrompts and they are easier to load
  • Updates how the normalizer handles converters. Namely, request and response converters are now consistent and can be applied in different ways (e.g. by index, data_type, etc). Previously, request converters were configured using the now deleted NormalizerRequestPiece
  • Tests updated

@rlundeen2 rlundeen2 merged commit 74dce4c into Azure:main Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants