MAINT: Add Import Sorting for Docs and Jupyter Notebooks (isort/nbqa-isort) #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When investigating jupytext for another story, I saw that we can sort in notebooks with an added argument
--treat-comment-as-code "# %%": PyCQA/isort#1338That led me to https://github.com/nbQA-dev/nbQA which runs
isorton Jupyter notebooks. Adding this with the profile set toblackas withisortso we can also use sorting ondoc\.py and .ipynb files without need of manual correction.Tests and Documentation