Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an export function to allow changing the default animation. #487

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Swellington-Soares
Copy link

Addition of an exports function to enable the use of custom animation directly in the script, thus eliminating external means of doing the same thing, taking advantage of what the script already offers.

Addition of an exports function to enable the use of custom animation directly in the script, thus eliminating external means of doing the same thing, taking advantage of what the script already offers.
@AvarianKnight
Copy link
Owner

This seems like something that should be a ConVar, not an export.

@Swellington-Soares
Copy link
Author

This seems like something that should be a ConVar, not an export.

I also thought about this, but on the other hand the server dev may want to create a script that allows, for example, the user to choose the custom animation from a list. That's why I put it as exports.

@AvarianKnight AvarianKnight reopened this Sep 19, 2024
@AvarianKnight
Copy link
Owner

You missed a call under this to free the animation when its no longer needed

if shouldPlayAnimation then
  RemoveAnimDict('random@arrests')
end

client/module/radio.lua Outdated Show resolved Hide resolved
Co-authored-by: Dillon Skaggs <[email protected]>
@AvarianKnight
Copy link
Owner

You missed a call under this to free the animation when its no longer needed

if shouldPlayAnimation then
  RemoveAnimDict('random@arrests')
end

removed anim dict correctly
@Swellington-Soares
Copy link
Author

I believe this time it fixes it.

@AvarianKnight
Copy link
Owner

Just a bump here, didn't forget about this, just need to test this along side other changes I have stashed away :)

Copy link

stale bot commented Nov 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 28, 2024
@stale stale bot closed this Dec 5, 2024
@AvarianKnight AvarianKnight reopened this Dec 31, 2024
@AvarianKnight AvarianKnight added todo Something that will be done in the future and removed wontfix This will not be worked on labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Something that will be done in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants