-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sell with woo tour #7549
Show sell with woo tour #7549
Conversation
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #7549 +/- ##
=========================================
Coverage 51.77% 51.77%
- Complexity 11307 11309 +2
=========================================
Files 640 640
Lines 48116 48121 +5
Branches 467 467
=========================================
+ Hits 24912 24917 +5
Misses 22826 22826
Partials 378 378
Continue to review full report in Codecov by Sentry.
|
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the existing tours continue working properly.
Test the previous changes of this PR with WordPress Playground. |
Resolves part of https://github.com/Automattic/sensei-pro/issues/2549
Proposed Changes
We were using Sensei's assets loader to load js paths. This will work for Sensei, but when Sensei-pro or any other third party tries to do the same, this won't work. So to make it more widely useable, we're now using callbacks for loading the tours. This will allow more extensibility.
Testing Instructions
Pre-Merge Checklist