Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sell with woo tour #7549

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Show sell with woo tour #7549

merged 4 commits into from
Mar 26, 2024

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Mar 19, 2024

Resolves part of https://github.com/Automattic/sensei-pro/issues/2549

Proposed Changes

We were using Sensei's assets loader to load js paths. This will work for Sensei, but when Sensei-pro or any other third party tries to do the same, this won't work. So to make it more widely useable, we're now using callbacks for loading the tours. This will allow more extensibility.

Testing Instructions

  1. Please check https://github.com/Automattic/sensei-pro/pull/2555

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@Imran92 Imran92 added this to the 4.22.0 milestone Mar 19, 2024
@Imran92 Imran92 requested a review from a team March 19, 2024 12:02
@Imran92 Imran92 self-assigned this Mar 19, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.77%. Comparing base (3288498) to head (9fead14).
Report is 3 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7549   +/-   ##
=========================================
  Coverage     51.77%   51.77%           
- Complexity    11307    11309    +2     
=========================================
  Files           640      640           
  Lines         48116    48121    +5     
  Branches        467      467           
=========================================
+ Hits          24912    24917    +5     
  Misses        22826    22826           
  Partials        378      378           
Files Coverage Δ
includes/admin/class-sensei-tour.php 90.90% <100.00%> (+0.90%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a661e...9fead14. Read the comment docs.

Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 marked this pull request as ready for review March 19, 2024 15:56
renatho
renatho previously approved these changes Mar 19, 2024
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the existing tours continue working properly.

@donnapep donnapep removed this from the 4.22.0 milestone Mar 20, 2024
@Imran92 Imran92 added this to the 4.23.0 milestone Mar 21, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

@Imran92 Imran92 merged commit df5a7d8 into trunk Mar 26, 2024
24 of 25 checks passed
@Imran92 Imran92 deleted the add/show-sell-with-woo-tour branch March 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants