-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle to pre-publish panel to publish lessons when course is published #7536
Conversation
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #7536 +/- ##
============================================
- Coverage 51.93% 51.93% -0.01%
- Complexity 11267 11277 +10
============================================
Files 630 631 +1
Lines 47665 47710 +45
Branches 420 421 +1
============================================
+ Hits 24756 24779 +23
- Misses 22572 22594 +22
Partials 337 337
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well. Just left a couple of small comments about doc tags.
Test the previous changes of this PR with WordPress Playground. |
Resolves #7457.
Proposed Changes
Add a Publish lessons toggle to the pre-publish panel. When enabled, any lessons associated with the course are published when the course is published.
Testing Instructions
Known Issue
The first time the course is viewed on the frontend, the following notice appears:
@renatho I know you did some work on notices not that long ago, including adding this one. Do you know of a simple way to solve this? If not, then I think I'll leave this as a known issue since the notice goes away on a refresh.
Pre-Merge Checklist