-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bulk_edit_posts hook for bulk edit handler #7526
Conversation
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #7526 +/- ##
============================================
- Coverage 51.93% 51.93% -0.01%
- Complexity 11267 11268 +1
============================================
Files 630 630
Lines 47665 47666 +1
Branches 420 420
============================================
Hits 24756 24756
- Misses 22572 22573 +1
Partials 337 337
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change @merkushin ! Looks like bulk_edit_posts
was introduced in WP 6.3.. I was wondering if we should wait until 6.3 becomes are minimum required version (25th of this month probably) or should conditionally handle it differently for lower versions (like keeping it working with save_post
but detaching the hook after first call). WDYT?
@Imran92 I think it is better to add a backward-compatibility version 👍 And it shouldn't be too hard (actually, that was one of my interim versions, but I removed it as I didn't find it useful 😅). |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
includes/class-sensei-lesson.php
Outdated
@@ -4321,38 +4325,59 @@ public function generate_all_lessons_edit_field( $title, $field ) { | |||
); | |||
} | |||
|
|||
/** | |||
* Save bulk edit fields. It is a backword compatible function for the bulk edit pre WP 6.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the word 'backward'
Test the previous changes of this PR with WordPress Playground. |
This PR addresses the issue with performance degradation, noticed here: #7523 (review).
Proposed Changes
Testing Instructions
Pre-Merge Checklist