Fix Psalm issues

Automattic · Jan 10, 2025 · 8dfd7b9 · 8dfd7b9
1 parent 099c3d0
commit 8dfd7b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/config/psalm/psalm-baseline.xml b/config/psalm/psalm-baseline.xml
@@ -187,9 +187,6 @@
     <InvalidArgument occurrences="1">
       <code>'course-category'</code>
     </InvalidArgument>
-    <PossibleRawObjectIteration occurrences="1">
-      <code>$cats</code>
-    </PossibleRawObjectIteration>
     <PossiblyFalseArgument occurrences="6">
       <code>$name</code>
       <code>$post_id</code>
@@ -201,9 +198,6 @@
     <PossiblyFalseReference occurrences="1">
       <code>is_enrolled</code>
     </PossiblyFalseReference>
-    <PossiblyInvalidIterator occurrences="1">
-      <code>$cats</code>
-    </PossiblyInvalidIterator>
     <PossiblyInvalidMethodCall occurrences="1">
       <code>get_provider_results</code>
     </PossiblyInvalidMethodCall>

diff --git a/includes/admin/class-sensei-learners-main.php b/includes/admin/class-sensei-learners-main.php
@@ -161,6 +161,7 @@ public function get_lesson_id() {
 	 * @return array $columns, the array of columns to use with the table
 	 */
 	public function get_columns() {
+		$columns = array();
 
 		switch ( $this->view ) {
 			case 'learners':
@@ -935,6 +936,8 @@ private function is_manually_enrolled( $user_id ) {
 	 * @return void
 	 */
 	public function no_items() {
+		$text = '';
+
 		switch ( $this->view ) {
 			case 'learners':
 				$text = __( 'No students found.', 'sensei-lms' );
@@ -1207,6 +1210,7 @@ public function add_learners_box() {
 	 * @return string $text
 	 */
 	public function search_button() {
+		$text = '';
 
 		switch ( $this->view ) {
 			case 'learners':