feat: handle user deletion event on the network #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Hey @adekbadek,
I'm running into issues testing this one. A couple things:
- When I delete the propagated user from a node, I see the delete event, but the user is never deleted from the hub site. Here is what I see on the node:
And once the event propagates, this is what I see on the hub:
But the user is never deleted on the hub:
- Might be related to the above, but when a user is deleted, I am also seeing the user updated event trigger (pictured in the screenshots above). I would expect this event not to be needed once a user is deleted. I wonder if this also has something to do with why the user persists on the hub even after the deletion event is processed?
chickenn00dle
approved these changes
Apr 25, 2024
| require_once ABSPATH . 'wp-admin/includes/user.php'; | ||
|
|
||
| // Don't broadcast this deletion on the network. | ||
| add_filter( 'newspack_network_process_user_deleted', '__return_false' ); |
There was a problem hiding this comment.
Just noting this results in conflicting messaging in the logs where the account is logged as skipped, but then is logged as deleted:
[25-Apr-2024 14:07:47 UTC] [3110] /Users/raz/Sites/newspack/network/includes/class-data-listeners.php:103 User deletion with email: [email protected] was skipped due to filter use.
[25-Apr-2024 14:07:47 UTC] [3110] /Users/raz/Sites/newspack/network/includes/incoming-events/class-user-deleted.php:70 User [email protected] deleted.
Since the final log indicates the deletion was successful, I think this is not a blocker.
matticbot
pushed a commit
that referenced
this pull request
Apr 25, 2024
# [1.7.0-alpha.1](v1.6.0...v1.7.0-alpha.1) (2024-04-25) ### Features * handle user deletion event on the network ([#91](#91)) ([cf3df3b](cf3df3b))
|
🎉 This PR is included in version 1.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 15, 2024
# [1.7.0](v1.6.0...v1.7.0) (2024-05-15) ### Features * handle user deletion event on the network ([#91](#91)) ([cf3df3b](cf3df3b))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds user deletion handling.
(Note: this is a part of integrating the changes from the
data-integrity-improvementsbranch (#89))How to test the changes in this Pull Request:
network_user_deletedevent in the event log* can be sped up by running
wp newspack-network process-webhookson the node and thenwp newspack-network sync-allon the other node sitesOther information: