feat(content-distribution): remove "Quick Edit" from linked posts #200
+52
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because quick edit let's the user do stuff we don't want on linked posts, this justs removes it. On a node site check that all linked posts don't show "quick edit" on hover on the posts listing. Networked posts that are not linked should have it.
miguelpeixe
approved these changes
Jan 23, 2025
| use Newspack\Data_Events; | ||
| use Newspack_Network\Admin as Network_Admin; | ||
| use Newspack_Network\Content_Distribution as Content_Distribution_Class; |
There was a problem hiding this comment.
We've not been using an alias for this in other files, should we start doing so? I thin it'd be good to standardize this.
There was a problem hiding this comment.
I agree. It's super confusing naming without it, so that's why I aliased it, but I'm up for either. Do you have a preference?
There was a problem hiding this comment.
I'm ok with the alias, do you mind doing the same for other files?
There was a problem hiding this comment.
Not at all. Will do and push to this one 👍
|
I aliased all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because quick edit let's the user do stuff we don't want on linked posts, this just removes it.
How to test
On a node site check that all linked posts don't show "quick edit" on hover on the posts listing. Networked posts that are not linked should still have it.
Posts not networked should also have it (note that distributor also hides it, so not those posts).