-
Notifications
You must be signed in to change notification settings - Fork 520
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bodybag and buckling layer fixes (#20174)
This PR is mostly about fixing body/cryo bag layering issues. Currently live and annoying to try and treat around: ![image](https://github.com/user-attachments/assets/b867af9a-8ab1-42cc-8503-bb252a3a86c7) Currently, bags are are below roller beds when first deployed. If buckled and unbuckled, they are then above, because of the + 0.1 on buckling. If buckled on a roller bed, dragged, and then unbuckled, they are then above player mobs, because of the `layer + 1` on roller bed `Move()` proc, which also doesn't get reset. I removed this +1 on Move() because it was older than the +0.1 and seems to serve the same purpose. The +0.1 did not have a method of reverting to the original buckled atom's layer, so I added a var and check to handle that. I also changed bullet casing's layer to `BELOW_TABLE_LAYER` with the intent of not having them on top of stasis bags and roller beds, because it causes issues as someone trying to treat wounded after a firefight. Changing bullet casing's layer does have a consequence of putting bullets underneath, for example, the soil in the public garden. Putting the soil on `BELOW_TABLE_LAYER` would fix this, but with the consequence of having the bushes be on top, making clicking the soil difficult for farming purposes. Adding bushes to that layer causes consequences with side window layering (like on deck three outside the public lounge.) For this PR I only adjusted the bullet casing layer. I'm sure it has other unintended layering interactions. Let me know if it would be better to leave them where they are or on some other layer. Current changes in PR: Bullets under soil/roller beds/stasis bags. ![image](https://github.com/user-attachments/assets/b56b768f-b9d6-4aca-ad2a-cfc30fe6e66a) (Example of why making bullets on top of soil is difficult) Screenshot shows both bullets and the soil being `BELOW_TABLE_LAYER` with bushes on top, as a reference. PR Currently has bullets underneath soil. ![image](https://github.com/user-attachments/assets/8cbf4b6d-8023-4138-86f1-f4cac106f647)
- Loading branch information
1 parent
b5064af
commit 8a20610
Showing
7 changed files
with
76 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
html/changelogs/AlaunusLux-bodybag-and-buckling-layer-fixes.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
################################ | ||
# Example Changelog File | ||
# | ||
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. | ||
# | ||
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) | ||
# When it is, any changes listed below will disappear. | ||
# | ||
# Valid Prefixes: | ||
# bugfix | ||
# - (fixes bugs) | ||
# wip | ||
# - (work in progress) | ||
# qol | ||
# - (quality of life) | ||
# soundadd | ||
# - (adds a sound) | ||
# sounddel | ||
# - (removes a sound) | ||
# rscadd | ||
# - (adds a feature) | ||
# rscdel | ||
# - (removes a feature) | ||
# imageadd | ||
# - (adds an image or sprite) | ||
# imagedel | ||
# - (removes an image or sprite) | ||
# spellcheck | ||
# - (fixes spelling or grammar) | ||
# experiment | ||
# - (experimental change) | ||
# balance | ||
# - (balance changes) | ||
# code_imp | ||
# - (misc internal code change) | ||
# refactor | ||
# - (refactors code) | ||
# config | ||
# - (makes a change to the config files) | ||
# admin | ||
# - (makes changes to administrator tools) | ||
# server | ||
# - (miscellaneous changes to server) | ||
################################# | ||
|
||
# Your name. | ||
author: AlaunusLux | ||
|
||
# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. | ||
delete-after: True | ||
|
||
# Any changes you've made. See valid prefix list above. | ||
# INDENT WITH TWO SPACES. NOT TABS. SPACES. | ||
# SCREW THIS UP AND IT WON'T WORK. | ||
# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. | ||
# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. | ||
changes: | ||
- bugfix: "Body/Cryo bags will now be above roller beds when deployed." | ||
- bugfix: "Body/Cryo bags will no longer be above player mobs after being buckled and dragged." | ||
- bugfix: "Bullets will no longer be on top of roller beds and body/cryo bags." | ||
- bugfix: "A buckled atom's layer will now be reset upon being unbuckled." |