[PAY-3823] Fix solscan link for transfer received #11079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DejayJD
changed the title
| href={ | ||
| transactionDetails.method === TransactionMethod.SEND | ||
| ? makeSolanaTransactionLink(transactionDetails.metadata) | ||
| : makeSolanaAccountLink(transactionDetails.metadata) |
There was a problem hiding this comment.
i think this might need to be a bit more sophisticated of a check - I think we should instead check on whether it's a valid solana wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solscan link for $AUDIO received was broken, it was trying to link to a transaction with the user's wallet.
Instead I changed the link to point at their wallet account on Solscan.
From:
https://solscan.io/tx/89SYrjUYJjieANbQohfsTsffeycpuLwZCcNjjSh9x6nW
to
https://solscan.io/account/89SYrjUYJjieANbQohfsTsffeycpuLwZCcNjjSh9x6nW
How Has This Been Tested?
web:prod