Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert a parameter in grid_based_sweep_coverage_path_planner to correct the planning results #917

Conversation

ssr-yuki
Copy link
Contributor

@ssr-yuki ssr-yuki commented Oct 11, 2023

Reference issue

This PR resolves #915 .

What does this implement/fix?

This PR just reverts the undesirable parameter change in PathPlanning/GridBasedSweepCPP/grid_based_sweep_coverage_path_planner.py summarised in #915 .

Additional information

N/A

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After CI becomes green. I will merge it.

@AtsushiSakai AtsushiSakai merged commit 2c4d745 into AtsushiSakai:master Oct 15, 2023
5 checks passed
@ssr-yuki ssr-yuki deleted the hotfix/param_of_grid_based_sweep_coverage_path_planner branch October 18, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing grid_based_sweep_coverage_path_planner.py
2 participants