Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: TokenFile with DerivedState #160

Merged
merged 12 commits into from
Sep 18, 2024
Merged

Refactor: TokenFile with DerivedState #160

merged 12 commits into from
Sep 18, 2024

Conversation

y-myajima
Copy link
Contributor

@y-myajima y-myajima commented Sep 18, 2024

Description

Refactor Token File feature with DerivedState.
Related Issue: #113

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge

Signed-off-by: myajima <[email protected]>
Signed-off-by: myajima <[email protected]>
Signed-off-by: myajima <[email protected]>
Signed-off-by: myajima <[email protected]>
Signed-off-by: myajima <[email protected]>
@y-myajima y-myajima changed the title derived token cache Refactor: TokenFile with DerivedState Sep 18, 2024
Signed-off-by: myajima <[email protected]>
Signed-off-by: myajima <[email protected]>
@y-myajima y-myajima self-assigned this Sep 18, 2024
@y-myajima y-myajima added the refactor Changes without functional changes, or api changes) label Sep 18, 2024
Copy link
Contributor

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

pkg/config/derived-token-file.go Outdated Show resolved Hide resolved
pkg/token/service.go Outdated Show resolved Hide resolved
pkg/config/dervied.go Outdated Show resolved Hide resolved
pkg/config/derived-target-domain-roles.go Show resolved Hide resolved
pkg/config/default.go Outdated Show resolved Hide resolved
pkg/config/derived-token-file.go Outdated Show resolved Hide resolved
pkg/config/derived-token-file.go Show resolved Hide resolved
pkg/config/derived-token-file.go Outdated Show resolved Hide resolved
pkg/token/service.go Outdated Show resolved Hide resolved
pkg/config/model.go Outdated Show resolved Hide resolved
Signed-off-by: myajima <[email protected]>
@y-myajima y-myajima requested a review from mlajkim September 18, 2024 03:37
Copy link
Contributor

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fum1h1to fum1h1to merged commit b9fbc6c into main Sep 18, 2024
8 checks passed
@fum1h1to fum1h1to deleted the derived-token-file branch September 18, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes without functional changes, or api changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants