Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role cert with derived state and its new config #145

Merged
merged 18 commits into from
Sep 14, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Sep 13, 2024

Description

Refactor RoleCert feature with DerivedState.
Related Issue: #113

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge

@mlajkim mlajkim added the refactor Changes without functional changes, or api changes) label Sep 13, 2024
@mlajkim mlajkim self-assigned this Sep 13, 2024
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/derived-access-token.go Show resolved Hide resolved
pkg/config/derived-role-cert.go Outdated Show resolved Hide resolved
Signed-off-by: Aaron Jeongwoo Kim <[email protected]>
Copy link
Contributor

@y-myajima y-myajima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlajkim mlajkim merged commit 01e06df into main Sep 14, 2024
8 checks passed
@mlajkim mlajkim deleted the role-cert-with-derived-state-and-its-new-config branch September 14, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes without functional changes, or api changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants