Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifiy the version numbers/commit hashes and fix setup.py #96

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

jkretz
Copy link
Collaborator

@jkretz jkretz commented Nov 12, 2021

Closes #94 and closes #95

This PR addresses two issues:

  • The version numbers/commit of packages needed to run the checker are now specified. This prevents that a downstream change in a requited package will break the checker.
  • Furthermore, this PR fixes the setup.py so that one can install the checker from the remote repo without the need to clone it. As not all the requirements can be solved via pip (i.e. udunits), there still is a combination of pip and conda to install the necessary packages. The installation instructions for installing the checker from the remote repo via pip are as follows:
    conda create --name atmodat python=3.8 pip udunits
    conda activate atmodat
    pip install git+https://github.com/AtMoDat/atmodat_data_checker@set_version_hash
    @wachsylon maybe you can have a look at that?

@jkretz
Copy link
Collaborator Author

jkretz commented Nov 15, 2021

I will merge this for now as the changes to setup.py are needed in #97 as well. For now, I won't amend the installation instructions, as I plan to revise them later when addressing #93.

@jkretz jkretz merged commit 29c2556 into master Nov 15, 2021
@jkretz jkretz deleted the set_version_hash branch November 16, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant