Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run notebook tests in parallel #145

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Run notebook tests in parallel #145

merged 10 commits into from
Nov 22, 2023

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Nov 20, 2023 •
edited
Loading

  • Split notebook job in MICADO and METIS to run them in parallel. Setup is still copy-pasted, because caching takes too much brain to do right, and the execution time is by far dominated by the actual running of notebooks, so it doesn't matter.
  • Add Python 3.12 to (non-notebook) test matrix. This actually caused one error, which is now also fixed.
  • Add slow marker for pytest to the slowest few (non-notebook) tests, which is not currently used by the CI. Also caught one case where the webtest marker should have been applied, but wasn't.
  • Some small improvements to make the CI runs nicer to look at.
  • Prepare to do something smarter with the "Badge Report" files.

@teutoburg teutoburg linked an issue Nov 20, 2023 that may be closed by this pull request
Run notebook tests in parallel? #144
Closed
@teutoburg teutoburg self-assigned this Nov 20, 2023
@teutoburg teutoburg added validation Cross-checking results with references irdb functionality Publish script, packaging, badges etc. labels Nov 20, 2023
@teutoburg teutoburg marked this pull request as ready for review November 21, 2023 13:25
hugobuddel
hugobuddel approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for speeding things up

@teutoburg teutoburg merged commit ce56795 into dev_master Nov 22, 2023
21 checks passed
@teutoburg teutoburg deleted the 144-run-notebook-tests-in-parallel branch November 22, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobuddel hugobuddel hugobuddel approved these changes

@astronomyk astronomyk Awaiting requested review from astronomyk

Assignees

@teutoburg teutoburg

Labels
irdb functionality Publish script, packaging, badges etc. validation Cross-checking results with references
Projects
ScopeSim-development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run notebook tests in parallel?
2 participants
@teutoburg @hugobuddel