Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if description exists first #140

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix: Check if description exists first #140

merged 1 commit into from
Feb 12, 2024

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Feb 12, 2024

check if description exists first

Both dapps endpoint rely on this.getDappsData but only one needs description.

dapps-staking/dapps          --> this._firebaseService.getDappsFull --> this.getDappsData
dapps-staking/dappssimple    --> this._firebaseService.getDapps     --> this.getDappsData
dapps-staking/dapps/:address --> this._firebaseService.getDapp

Copy link

Visit the preview URL for this PR (updated for commit cca09f7):

https://astar-token-api--pr140-fix-dappssimple-h5xpvubg.web.app

(expires Mon, 19 Feb 2024 15:40:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

@gluneau gluneau changed the title check if description exists first fix: Check if description exists first Feb 12, 2024
@gluneau gluneau merged commit 6ad74ba into prod Feb 12, 2024
5 checks passed
@gluneau gluneau deleted the fix/dappssimple branch February 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants