Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: total number of v3 stakers #126

Merged
merged 3 commits into from
Jan 26, 2024
Merged

feat: total number of v3 stakers #126

merged 3 commits into from
Jan 26, 2024

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Jan 15, 2024

Adds the total number of v3 stakers to the api

Copy link

github-actions bot commented Jan 15, 2024

Visit the preview URL for this PR (updated for commit d67452a):

https://astar-token-api--pr126-feat-stakingv3-stake-0dimc7pj.web.app

(expires Fri, 02 Feb 2024 04:18:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

@Kahonnohak Kahonnohak requested a review from bobo-k2 January 17, 2024 02:16
@bobo-k2
Copy link
Contributor

bobo-k2 commented Jan 18, 2024

The total number of stakers shows sum of stakers per dApp, which is not correct since one person can stake on multiple dApps. Maybe I wasn't clear before and I am sorry. We are looking unique number of stakers.

@gluneau gluneau changed the title stakerscount-total feat: total number of v3 stakers Jan 19, 2024
@gluneau
Copy link
Contributor Author

gluneau commented Jan 26, 2024

It is now distinct stakers, fixed upstream AstarNetwork/dapps-staking-indexer-v3#14

@gluneau gluneau merged commit be56ca7 into prod Jan 26, 2024
5 checks passed
@gluneau gluneau deleted the feat/stakingv3-stakerscount branch January 26, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants