Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace lfgm #1427

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Feature/replace lfgm #1427

merged 7 commits into from
Dec 18, 2024

Conversation

codespool
Copy link
Contributor

Pull Request Summary

replace LFGM banner with Surge banner

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • Surge coin gif

Changes

  • banner link
  • gif styles

To-dos

  • replace gif with better optimised one

Copy link

github-actions bot commented Dec 17, 2024

Visit the preview URL for this PR (updated for commit 677b6ec):

https://astar-apps--pr1427-feature-replace-lfgm-l3mdcovo.web.app

(expires Wed, 25 Dec 2024 09:21:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

Thank you!!!

  1. Could we add tooltip "Join Astar Surge"? We need something to mention where it goes.
  2. Could you make the gif height 100px for desktop (mobile looks cool) but keep the area height as it is (150px) ? --> would like to make the gif smaller and want to make space between menu and Surge area.
  3. we go webp if this is better please replace (I cannot add webp here so I'll give it to you on Slack)

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@codespool codespool merged commit 4529735 into hotfix Dec 18, 2024
5 of 6 checks passed
@codespool codespool deleted the feature/replace-lfgm branch December 18, 2024 13:11
@codespool codespool restored the feature/replace-lfgm branch December 18, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants