-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dAppStaking): Move actions mechanisms for bonus rewards #1402
Open
ipapandinas
wants to merge
8
commits into
master
Choose a base branch
from
feat/move_bonus_dapp_staking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/bench shibuya-dev pallet_dapp_staking |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/12753557202. |
ipapandinas
changed the title
WIP - feat(dAppStaking): Move actions mechanisms for bonus rewards
feat(dAppStaking): Move actions mechanisms for bonus rewards
Jan 13, 2025
Benchmarks have been finished. |
ipapandinas
added
shibuya
related to shibuya
runtime
This PR/Issue is related to the topic “runtime”.
and removed
shibuya
related to shibuya
labels
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dapps-staking
Dapps Staking
enhancement
New feature or request
runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR introduces enhancements to the bonus reward eligibility mechanism and implements robust handling for stake movement, particularly during the
build&earn
subperiod.Bonus Reward Eligibility
The previously used
loyal_staker
flag is replaced with and decoded into abonus_status
enum:This update:
MaxBonusMovesPerPeriod
).Move action
A move action is defined as either:
If a move action is performed during the
build&earn
subperiod, thebonus_status
attached to the relevant singular staking info is reduced until it is forfeited.Stake Movement Enhancements
A new
move_stake
extrinsic is implemented. It is similar to an 'unstake' followed by two 'stakes' for each subperiod. Existing safeguards are extended additional checks to:When moving stake from unregistered contracts, the bonus status is always preserved.
Migration
A multi-block migration is proposed to convert all existing
loyal_staker
flags to their respective BonusStatus variants:BonusStatus::SafeMovesRemaining(0)
for true.BonusStatus::BonusForfeited
for false.Closes #1379
Check list