Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip WASM build for clippy #1217

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Skip WASM build for clippy #1217

merged 1 commit into from
Apr 4, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Apr 3, 2024

Optimize clippy by skipping the WASM build.

Reduces execution time from ~10minutes to ~5minutes.

@Dinonard Dinonard added the other PR/issue is related to third-party, scripts or other things which don't have definite label. label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/unified-accounts/src 100% 0%
precompiles/xvm/src 74% 0%
pallets/astar-xcm-benchmarks/src 87% 0%
precompiles/sr25519/src 64% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
primitives/src/xcm 65% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/inflation/src 83% 0%
chain-extensions/types/assets/src 0% 0%
pallets/unified-accounts/src 85% 0%
precompiles/dapps-staking/src 93% 0%
pallets/collator-selection/src 91% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
primitives/src/migrations 0% 0%
pallets/block-rewards-hybrid/src 91% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-v3/src 91% 0%
pallets/dapps-staking/src 89% 0%
pallets/static-price-provider/src 52% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/ethereum-checked/src 79% 0%
pallets/xc-asset-config/src 64% 0%
primitives/src 29% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/xvm/src 51% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/xcm/src 73% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/price-aggregator/src 72% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
Summary 76% (4416 / 5845) 0% (0 / 0)

Minimum allowed line rate is 50%

@mc2eqe
Copy link
Contributor

mc2eqe commented Apr 3, 2024

@Dinonard
Copy link
Member Author

Dinonard commented Apr 4, 2024

Syntax is ok. Does it work as expected? I found this:

* https://github.com/bifrost-finance/bifrost/blob/develop/Makefile#L71

* https://github.com/reef-defi/reef-chain/blob/master/Makefile#L42

Yes, it works as expected.

@mc2eqe
Copy link
Contributor

mc2eqe commented Apr 4, 2024

Approved

@Dinonard Dinonard merged commit dcc393d into master Apr 4, 2024
9 of 10 checks passed
@Dinonard Dinonard deleted the ci/clippy-optimization branch April 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other PR/issue is related to third-party, scripts or other things which don't have definite label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants