XVM CE: Sufficient charged gas check before XVM execution. #1073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #1070
I tried to add an integration test to cover the checks, but the out-of-gas check in
pallet-contracts
has a big margin. i.e. it requires the weight limit to be much higher than the actual used weight, or theOutOfGas
error is returned. @PierreOssun might have some info on this?In addition to the issue above, the charged weight at the beginning of the CE is updated to all the gas left, instead of the gas left with a
30KB
dummy value.Check list