Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove AccountMapping trait #1067

Merged
merged 3 commits into from
Oct 31, 2023
Merged

feat: remove AccountMapping trait #1067

merged 3 commits into from
Oct 31, 2023

Conversation

ashutoshvarma
Copy link
Member

Closes #1057

Pull Request Summary

  • Replace all instances of AccountMapping trait with UnifiedAddressMapper.
  • Introduce HashedDefaultMappings impl for UnifiedAddressMapper to cover default mappings (for use in AU PR and mock)

@ashutoshvarma ashutoshvarma added runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya labels Oct 24, 2023
primitives/src/evm.rs Show resolved Hide resolved
primitives/src/evm.rs Show resolved Hide resolved
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/assets/src 0% 0%
pallets/dapps-staking/src 81% 0%
precompiles/sr25519/src 79% 0%
pallets/dapps-staking/src/pallet 85% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/utils/src 55% 0%
precompiles/utils/macro/src 0% 0%
precompiles/utils/src/testing 38% 0%
precompiles/xcm/src 75% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/substrate-ecdsa/src 78% 0%
primitives/src 65% 0%
chain-extensions/dapps-staking/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/block-reward/src 85% 0%
pallets/contracts-migration/src 0% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
primitives/src/xcm 66% 0%
chain-extensions/types/dapps-staking/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/unified-accounts/src 83% 0%
pallets/collator-selection/src 69% 0%
precompiles/xvm/src 75% 0%
pallets/xvm/src 40% 0%
Summary 56% (2209 / 3939) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good cleanup

@shaunxw shaunxw merged commit 462f2a2 into master Oct 31, 2023
8 checks passed
@shaunxw shaunxw deleted the feat/au-refactor branch October 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: replace 'AccountMapping' with 'UnifiedAddressMapper' trait
3 participants