-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple chain support for benchmarking #1060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
mc2eqe
requested review from
Dinonard,
shaunxw,
gitofdeepanshu and
ehsanhajian
October 17, 2023 14:19
Dinonard
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR description is missing 😄
gitofdeepanshu
approved these changes
Oct 17, 2023
# Benchmark each pallet. | ||
for PALLET in "${PALLETS[@]}"; do | ||
NAME_PRFX=${PALLET#*_} | ||
NAME=${NAME_PRFX//::/_} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running benchmarks only allows user to specify one runtime at a time.
This is problematic if we want to benchmark all of them at once, since each trigger
will rebuild the entire binary which takes time.
To improve this, suggestion is to change
[chain name] - astar-dev, shiden-dev, shibuya-dev, dev
[pallet names] - Use "," for multiple pallets, "all" for all pallets
/bench [chain name] [pallet names]
into
[chain names] - Use "," for multiple runtimes. Available values are: astar-dev, shiden-dev, shibuya-dev, dev
[pallet names] - Use "," for multiple pallets, "all" for all pallets
/bench [chain names] [pallet names]
Pull Request Summary
Check list