SSTORE2-compatible dependency registry (for scripts) #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerockland
changed the base branch from
main
to
dependency-registry-v0-updates
…/artblocks-contracts into dependency-registry-v0-updates
…-dependency-registry
jakerockland
changed the title
jakerockland
requested review from
ryley-o and
yoshiwarab
and removed request for
a team
ryley-o
reviewed
Jul 25, 2023
ryley-o
reviewed
Jul 25, 2023
ryley-o
reviewed
Jul 25, 2023
ryley-o
reviewed
Jul 25, 2023
…rtBlocks/artblocks-contracts into sstore2-compatible-dependency-registry
ryley-o
approved these changes
Jul 25, 2023
jakerockland
added a commit
to ArtBlocks/artblocks-subgraph
that referenced
this pull request
Jul 25, 2023
Minor adjustment to be consistent with consistency adjustments made in: ArtBlocks/artblocks-contracts#895
Thank you ser! Re-requesting another review pass if that is ok though, given meaningful changes made across the entirety of the file for consistency purposes based on feedback. |
ryley-o
approved these changes
Jul 25, 2023
…rtBlocks/artblocks-contracts into sstore2-compatible-dependency-registry
yoshiwarab
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR makes a few interrelated changes:
BytecodeStoragelibrary implementation, but also provide fallback support for pointing toSSTORE2-written data.BytecodeStoragelibrary or an unknown library (which we will fallback to reading as anSSTORE2written blob).Appropriate test coverage is also added for these changes.
As discussed internally, the rationale for this change is to allow the reuse of referencing existing uploads of dependencies that may already exist on chain (e.g. an upload of p5js 1.0.0 that has already been uploaded on-chain via EthFS) as script versions that the dependency registry is aware of, without requiring the superfluous re-upload of these script references on-chain in their entirety.